Re: procps-ng 3.3.17 released
Craig Small <[email protected]> Wed, 10 Feb 2021 06:31:18 +1100
| Newsgroups | gmane.linux.procps.devel |
|---|---|
| Message-ID | <CALy8Cw53NSOQ7CzKZ38mEH0=JawpCTzedwAXyJcg34e8SNtAQQ@mail.gmail.com> |
Hi, On Tue, 9 Feb 2021 at 23:52, Adam Sampson <[email protected]> wrote: > - The directory name inside the tarball doesn't match the tarball name: > it's called procps-3.3.17, rather than procps-ng-3.3.17. Many > packaging tools will expect these to be the same (as they were in > previous releases). > That was the case in Debian about, I think it was a decade ago, I remember that issue with apache 2.0, most packaging setups don't seem to care now unless you're starting from a blank slate. I can repack that easily enough. - The test suite fails -- when pkill is invoked by the testsuite, the > binary name is something like "lt-pkill", and the new code added for > pwait doesn't handle this. So the pkill tests can't work as written. > I think this depends on the version of libtool. All my "real binaries" (the ones hiding under .lib) don't have the lt- prefix anymore which is why my tests run fine. I'll add the additional check in anyway. - Craig > The old version of the code used strstr rather than strcmp to compare > the names; I've attached a patch to make the new code do the same. > > Thanks, > > -- > Adam Sampson <[email protected]> <http://offog.org/> >