Re: some procps--n4-4.0.0 fixes

Craig Small <[email protected]> Sat, 9 Apr 2022 13:23:26 +1000
Newsgroups gmane.linux.procps.devel
Message-ID <CALy8Cw7_GOBgiX3bQLPqyXZv9b-CDtiZ2wnv68NAFLohbns8ww@mail.gmail.com>
On Fri, 8 Apr 2022 at 22:49, Dr. Werner Fink <[email protected]> wrote:

> I've a bug report due to new behaviour of sysctl which is a regression
>
>     * sysctl: Check resolved path to be under /proc/sys      issue #179
>
> Are you sure it is that one? I did a git bisect on the master branch and
it was a change introduced in
commit 474847ed35dda5fd4c33a717d8cc7c4d17b90232 in master branch
and 6389deca5bf667f5fab5912acde78ba8e0febbc7 in newlib
which was actually issue #191 not #179

master has the same issue and doesn't have that fix.

I suspect it is
https://gitlab.com/procps-ng/procps/-/commit/6389deca5bf667f5fab5912acde78ba8e0febbc7#2ac4d3e6ddf3306cb8fcbae7b632520feb2ff20e_506_572
vs
https://gitlab.com/procps-ng/procps/-/commit/6389deca5bf667f5fab5912acde78ba8e0febbc7#2ac4d3e6ddf3306cb8fcbae7b632520feb2ff20e_521_599

as the old line used outname and the new uses path.

I don't think I can write an automatic test for this as writing to /proc
needs root, but if someone knows a user-writable key somewhere let me know.

- Craig