Re: top enhancements + 2 bugs swatted

"Craig Small" <[email protected]> ("csmall") Mon, 12 Sep 2022 22:35:15 +1000
Newsgroups gmane.linux.procps.devel
Message-ID <CALy8Cw5tO-q0LKcz_+JiH+CAdUHC48ihLXMeD1ei49uU7VbVQw@mail.gmail.com>
Hi Jim,

  Those changes are pushed now. look_up_ourself() becomes more and more not
what it was, but it's an internal function so doesn't matter so much.

My desktop has 12 cores so that I can get 8 across, nice!

My question is how the memory is displayed. It's more of a style thing than
anything significant.
I have a monitor with strange dimensions, 282 columns by 55 lines. So the
CPUs nicely stretch across the 282 columns 8-across.
The memory when it's just numbers seems to stay firmly in 80-column land.
The graphs get squished up like the CPUs, even though there is real estate
to the right of them.

I've attached two screen-shots showing this.

 - Craig



On Sun, 11 Sept 2022 at 05:02, Jim Warner <[email protected]> wrote:

> Hi Craig,
>
> I finally got around to implementing something I've wanted to do for
> awhile.  The attached tarball with 9 patches represents that effort.
>
> In addition to improved graph mode scaling and the elimination of some
> useless #define's, top can now display up to 8 cpus on a single summary
> line.
>
> I also discovered a SIGWINCH bug introduced when top's bottom window
> changes were made more responsive.  And a more serious library bug was
> addressed too.
>
> It sure would be nice to sneak these changes into 4.0.1.
>
> Regards,
>
> Jim
top-graph.png (image/png, 21.1 KB) - not displayed
top-numbers.png (image/png, 24.6 KB) - not displayed