Re: RFC: Using openat()

--00000000000007712305f2eae2c4
Content-Type: text/plain; charset="UTF-8"

On Sat, 21 Jan 2023 at 05:04, Jim Warner <[email protected]> wrote:

> time.  After all, the migration to libproc2 is already huge.  Why not
> let that dust settle first.
>
That's a good point. I've been to and fro'ing about should it be in this
next release but that makes sense to delay.


> form this patch breaks the top and w programs.  Part of the problem
> appears to involve a potential closing of STDIN_FILENO.
>
w works fine here, wonder what the difference is?
top.. yeah that's a very interesting effect! Sort of disco-top


> Once over that hurdle, be sure to run top with the -H switch using
> valgrind to see if there are any invalid file descriptors.
>
 OK.

In that case, no openat() for next release.

 - Craig

--00000000000007712305f2eae2c4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Sat, 21 Jan 2023 at 05:04, Jim Warner =
&lt;<a href=3D"mailto:[email protected]">[email protected]</a=
>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex">time.=C2=A0 After all, the migration to libproc2 is=
 already huge.=C2=A0 Why not <br>
let that dust settle first.<br></blockquote><div>That&#39;s a good point. I=
&#39;ve been to and fro&#39;ing about should it be in this next release but=
 that makes sense to delay.</div><div>=C2=A0<br></div><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex">
form this patch breaks the top and w programs.=C2=A0 Part of the problem <b=
r>
appears to involve a potential closing of STDIN_FILENO.<br></blockquote><di=
v>w works fine here, wonder what the difference is?<br></div><div>top.. yea=
h that&#39;s a very interesting effect! Sort of disco-top</div><div>=C2=A0<=
br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Once over that hurdle, be sure to run top with the -H switch using <br>
valgrind to see if there are any invalid file descriptors.<br></blockquote>=
<div>=C2=A0OK.</div><div><br></div><div>In that case, no openat() for next =
release.</div><div><br></div><div>=C2=A0- Craig</div><div><br></div></div><=
/div>

--00000000000007712305f2eae2c4--