Re: [PATCH V3 1/6] block: ignore discard return value
Jens Axboe <[email protected]>
| Newsgroups | gmane.linux.file-systems.f2fs,gmane.linux.raid,gmane.linux.kernel,gmane.linux.block,gmane.linux.kernel.bpf |
|---|---|
| Message-ID | <[email protected]> |
On 11/25/25 12:09 PM, Chaitanya Kulkarni wrote: > On 11/25/25 09:38, Jens Axboe wrote: >> On 11/24/25 4:48 PM, Chaitanya Kulkarni wrote: >>> __blkdev_issue_discard() always returns 0, making the error check >>> in blkdev_issue_discard() dead code. >> Shouldn't it be a void instead then? >> > Yes, we have decided to clean up the callers first [1]. Once they are > merged safely, after rc1 I'll send a patch [2] to make it void since > it touches many different subsystems. OK, that make sense. I'll queue patch 1. -- Jens Axboe