Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE
hch <[email protected]>
| Newsgroups | gmane.linux.uml.devel,gmane.linux.ports.alpha,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.ports.sparc,gmane.linux.kernel.cryptoapi,gmane.comp.file-systems.btrfs,gmane.linux.kernel.cross-arch,gmane.linux.raid |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Feb 26, 2026 at 10:45:26PM +0100, Richard Weinberger wrote: > ----- Ursprüngliche Mail ----- > > Von: "hch" <[email protected]> > > XOR_SELECT_TEMPLATE is only ever called with a NULL argument, so all the > > ifdef'ery doesn't do anything. With our without this, the time travel > > mode should work fine on CPUs that support AVX2, as the AVX2 > > implementation is forced in this case, and won't work otherwise. > > IIRC Johannes added XOR_SELECT_TEMPLATE() here to skip > the template selection logic because it didn't work with time travel mode. > > Johannes, can you please test whether this change does not break > time travel mode? I'm pretty sure that was the intent, but as I wrote above it worked and still works on AVX-supporting CPUs by chance, and already doesn't on older CPUs, and unless my git blaming went wrong someewhere already didn't when this was originally added.