Re: [PATCH 17/25] s390: move the XOR code to lib/raid/
Christoph Hellwig <[email protected]>
| Newsgroups | gmane.linux.uml.devel,gmane.linux.ports.alpha,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.ports.sparc,gmane.linux.kernel.cryptoapi,gmane.comp.file-systems.btrfs,gmane.linux.kernel.cross-arch,gmane.linux.raid |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Feb 27, 2026 at 10:09:59AM +0100, Heiko Carstens wrote: > However, I just had a look at the s390 implementation and just saw that the > inline assembly constraints for xor_xc_2() are incorrect. "bytes", "p1", > and "p2" are input operands, while all three of them are modified within > the inline assembly. Given that the function consists only of this inline > assembly I doubt that this causes any harm, however I still want to fix > this now; but your patch should apply fine with or without this fixed. Two comments on that: I thin kin the long run simply moving the implementation to a pure assembly file might be easier to maintain. Also with this series you can now optimize for more than 5 stripes, which should be the mormal case. I'll try to make sure we'll get units tests to help with that.