Re: [PATCH 16/25] sparc: move the XOR code to lib/raid/
Christoph Hellwig <[email protected]>
| Newsgroups | gmane.linux.ports.ppc64.devel,gmane.linux.ports.alpha,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.ports.riscv,gmane.linux.ports.sparc,gmane.linux.uml.devel,gmane.linux.kernel.cryptoapi,gmane.comp.file-systems.btrfs,gmane.linux.kernel.cross-arch,gmane.linux.raid |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Feb 27, 2026 at 09:47:16PM -0800, Eric Biggers wrote: > On Thu, Feb 26, 2026 at 07:10:28AM -0800, Christoph Hellwig wrote: > > diff --git a/arch/sparc/lib/xor.S b/lib/raid/xor/sparc/xor-niagara.S > > similarity index 53% > > rename from arch/sparc/lib/xor.S > > rename to lib/raid/xor/sparc/xor-niagara.S > > index 35461e3b2a9b..f8749a212eb3 100644 > > --- a/arch/sparc/lib/xor.S > > +++ b/lib/raid/xor/sparc/xor-niagara.S > > @@ -1,11 +1,8 @@ > > /* SPDX-License-Identifier: GPL-2.0 */ > > /* > > - * arch/sparc64/lib/xor.S > > - * > > * High speed xor_block operation for RAID4/5 utilizing the > > - * UltraSparc Visual Instruction Set and Niagara store-init/twin-load. > > + * Niagara store-init/twin-load. > > * > > - * Copyright (C) 1997, 1999 Jakub Jelinek ([email protected]) > > * Copyright (C) 2006 David S. Miller <[email protected]> > > */ > > > > @@ -16,343 +13,6 @@ > > #include <asm/dcu.h> > > #include <asm/spitfire.h> > > > > <linux/export.h> can be removed from the two assembly files, since all > the invocations of EXPORT_SYMBOL() in them were removed. > > Also, xor-niagara.S ended up without a .text directive at the beginning. > Probably it was unnecessary anyway. However, this seems unintentional, > given that xor-vis.S still has it. I'll probably undo the split and just do the mechanical move for the next version. This was a bit too much change even if a split would be my preferred outcome.