Re: [PATCH 21/25] xor: add a better public API
Christoph Hellwig <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.ports.alpha,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.ports.riscv,gmane.linux.ports.sparc,gmane.linux.uml.devel,gmane.linux.kernel.cryptoapi,gmane.comp.file-systems.btrfs,gmane.linux.kernel.cross-arch,gmane.linux.raid |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Feb 27, 2026 at 10:50:38PM -0800, Eric Biggers wrote: > > +void xor_gen(void *dest, void **srcss, unsigned int src_cnt, > > + unsigned int bytes); > > srcss => srcs > > Ideally the source vectors would be 'const' as well. I looked at the constification, and it's a bit painful because the same source arrays are also passed to the raid6 code by the callers. I'll clean up the raid6 API first, and then will give it another spin.