Re: [PATCH 02/17] raid6: remove __KERNEL__ ifdefs
"H. Peter Anvin" <[email protected]>
| Newsgroups | gmane.linux.ports.riscv,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.ports.ppc64.devel,gmane.linux.kernel.cryptoapi,gmane.comp.file-systems.btrfs,gmane.linux.kernel.cross-arch,gmane.linux.raid |
|---|---|
| Message-ID | <[email protected]> |
On 2026-03-25 08:13, H. Peter Anvin wrote: > On 2026-03-23 23:40, Christoph Hellwig wrote: >> With the test code ported to kernel space, none of this is required. > > I really *really* don't like this. > > The ability of running in user space is really useful when it comes to > developing new code for new platforms, which happens often enough for this code. > That being said -- and I do say this as the original author of this code -- this should be reduced to the maximum extent possible to a (minimal) set of #ifndef __KERNEL__, which should be localized as much as possible. The actual user space components, even such a thing as a simple #include, should be moved to a separate user space header. But pretty please do leave the ability to debug the algorithms in user space. This is hard code to write and debug; it is not just about regression testing. -hpa