Re: [PATCH v2 0/5] md: bitmap grow fixes

On Tue 07 Apr 2026 at 18:26, Su Yue <[email protected]> wrote:

> Hi, This v2 series is to fixes bugs exposed by 
> mdadm/clustermd-autotest.
> The bugs are not cluster md only but also bitmap related.
>
> The series based on v7.0-rc7 passes tests with mdadm v4.6 
> without regression.
>
> v2:
>     Add a dummy bitmap operations per Kuai's suggestion.
>
> To Yu Kuai:
> A NULL group can't used for internal_bitmap_group since
> the entries from internal_bitmap_attrs should be under bitmap.
> So instead of sysfs_create_groups(), sysfs_create_group() and 
> sysfs_merge_group()
> are still needed /sigh.
>
> Su Yue (5):
>   md/md-bitmap: call md_bitmap_create,destroy in location_store
>   md/md-bitmap: add an extra sysfs argument to md_bitmap_create 
>   and
>     destroy
>   md/md-bitmap: add dummy bitmap ops for none to fix wrong 
>   bitmap offset
>   md: skip ID_BITMAP_NONE when show available bitmap types
>   md/md-bitmap: remove member group from bitmap_operations
>
Missing part should be added in v3:

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 20a953676319..453b89941db2 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6450,9 +6450,6 @@ static int start_dirty_degraded;

 int md_bitmap_create(struct mddev *mddev, bool create_sysfs)
  {
  -       if (mddev->bitmap_id == ID_BITMAP_NONE)
  -               return -EINVAL;
  -
}
>  drivers/md/md-bitmap.c   | 121 
>  ++++++++++++++++++++++++++++++++++++---
>  drivers/md/md-bitmap.h   |   3 +-
>  drivers/md/md-llbitmap.c |  13 ++++-
>  drivers/md/md.c          |  55 +++++++++---------
>  drivers/md/md.h          |   2 +
>  5 files changed, 155 insertions(+), 39 deletions(-)