On disk repos, anaconda, and Installation Source

Pat Riehecky <[email protected]> Fri, 14 Jun 2019 13:58:27 -0500
Newsgroups	gmane.linux.redhat.anaconda.devel
Message-ID	<[email protected]>
This is a multi-part message in MIME format.
--===============4137881365763708816==
Content-Type: multipart/alternative;
	boundary="------------E6F43F797D364601B9668BA6"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------E6F43F797D364601B9668BA6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

I noticed an unexpected behavior in Fedora 30.

The net install disk for Workstation ships with the 
'fedora-cisco-openh264' repo on the media.  However, the repo is not 
listed under the 'Installation Source' spoke.

Should this repo be loaded into the addons list?

I suppose this is a bit of confusion based on this comment [1], vs the 
actual behavior where only `.treeinfo` repos that are also on disk get 
enabled [2]

Thoughts?

Pat


[1] 
https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1144

[2] self.addons seems to be populated via __init__.py and what it finds 
in `.treeinfo` I think.
https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1235

-- 
Pat Riehecky

Fermi National Accelerator Laboratory
www.fnal.gov
www.scientificlinux.org


--------------E6F43F797D364601B9668BA6
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    I noticed an unexpected behavior in Fedora 30.<br>
    <br>
    The net install disk for Workstation ships with the
    'fedora-cisco-openh264' repo on the media.  However, the repo is not
    listed under the 'Installation Source' spoke.<br>
    <br>
    Should this repo be loaded into the addons list?<br>
    <br>
    I suppose this is a bit of confusion based on this comment [1], vs
    the actual behavior where only `.treeinfo` repos that are also on
    disk get enabled [2]<br>
    <br>
    Thoughts?<br>
    <br>
    Pat<span class="pl-c1"><br>
    </span><br>
    <br>
    [1]
<a class="moz-txt-link-freetext" href="https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1144">https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1144</a><br>
    <br>
    [2] self.addons seems to be populated via __init__.py and what it
    finds in `.treeinfo` I think.<br>
<a class="moz-txt-link-freetext" href="https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1235">https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1235</a><br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Pat Riehecky

Fermi National Accelerator Laboratory
<a class="moz-txt-link-abbreviated" href="http://www.fnal.gov">www.fnal.gov</a>
<a class="moz-txt-link-abbreviated" href="http://www.scientificlinux.org">www.scientificlinux.org</a></pre>
  </body>
</html>

--------------E6F43F797D364601B9668BA6--


--===============4137881365763708816==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Anaconda-devel-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--===============4137881365763708816==--