Re: On disk repos, anaconda, and Installation Source
Pat Riehecky <[email protected]> Wed, 19 Jun 2019 11:40:19 -0500
| Newsgroups | gmane.linux.redhat.anaconda.devel |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============7080581654285412061== Content-Type: multipart/alternative; boundary="------------D43C538A03CFF6E917410A24" Content-Language: en-US This is a multi-part message in MIME format. --------------D43C538A03CFF6E917410A24 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Thanks! I'll kick up a patch to change the comment to match the expected behavior. Pat On 6/19/19 7:22 AM, [email protected] wrote: > Hello, > > So about the code and treeinfo. This repository is not loaded because > it is disabled on the netboot image and the code is iterating only > between enabled repositories, which is the correct behavior I would say. > > Yes the comment is wrong, originally it was above the > ``self.set_updates_enabled(self._updates_enabled)`` line and the > meaning was that all the repos there will be enabled (under some > conditions) and user can adjust this by the checkbox in UI. The are of > course the conditions so it's not always so or so. That comment should > definitely change or the whole code should be rewritten to be more > readable. > > You can read the conditions if you follow the `enabled` variable in > this method. In short these local repositories will be enabled if > there is no installation method set and it is not automatic > installation -- (in other words "Closest mirror" installation). > > And no, this repositories shouldn't be loaded into the addon list > right now. We can think about that in the further changes but now it > is just implementation detail of the Closest mirror installation type. > > Cheers, > Jirka > > > On Fri, 2019-06-14 at 13:58 -0500, Pat Riehecky wrote: >> I noticed an unexpected behavior in Fedora 30. >> >> The net install disk for Workstation ships with the >> 'fedora-cisco-openh264' repo on the media. However, the repo is not >> listed under the 'Installation Source' spoke. >> >> Should this repo be loaded into the addons list? >> >> I suppose this is a bit of confusion based on this comment [1], vs >> the actual behavior where only `.treeinfo` repos that are also on >> disk get enabled [2] >> >> Thoughts? >> >> Pat >> >> >> [1] >> https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1144 >> >> [2] self.addons seems to be populated via __init__.py and what it >> finds in `.treeinfo` I think. >> https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1235 >> >> -- >> Pat Riehecky >> Fermi National Accelerator Laboratory >> www.fnal.gov >> www.scientificlinux.org >> _______________________________________________ >> Anaconda-devel-list mailing list >> [email protected] >> <mailto:[email protected]> >> https://www.redhat.com/mailman/listinfo/anaconda-devel-list >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.redhat.com_mailman_listinfo_anaconda-2Ddevel-2Dlist&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=OAMtP0DWou0nlXG7Kmxo2enjXJfwb1DXS9fwcaESuTE&m=4-xXxdgOoCnvekEgB8jVaDu3MGGrgDnGFUaMz7MMSFk&s=DzCyh5T0G7g1PQIoJGcku9Cj5kRfmZHQ2OQlmM4sGUY&e=> -- Pat Riehecky Fermi National Accelerator Laboratory www.fnal.gov www.scientificlinux.org --------------D43C538A03CFF6E917410A24 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> Thanks!<br> <br> I'll kick up a patch to change the comment to match the expected behavior.<br> <br> Pat<br> <br> <div class="moz-cite-prefix">On 6/19/19 7:22 AM, <a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a> wrote:<br> </div> <blockquote type="cite" cite="mid:[email protected]"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <div>Hello,</div> <div><br> </div> <div>So about the code and treeinfo. This repository is not loaded because it is disabled on the netboot image and the code is iterating only between enabled repositories, which is the correct behavior I would say.</div> <div><br> </div> <div>Yes the comment is wrong, originally it was above the ``self.set_updates_enabled(self._updates_enabled)`` line and the meaning was that all the repos there will be enabled (under some conditions) and user can adjust this by the checkbox in UI. The are of course the conditions so it's not always so or so. That comment should definitely change or the whole code should be rewritten to be more readable.</div> <div><br> </div> <div>You can read the conditions if you follow the `enabled` variable in this method. In short these local repositories will be enabled if there is no installation method set and it is not automatic installation -- (in other words "Closest mirror" installation). </div> <div><br> </div> <div>And no, this repositories shouldn't be loaded into the addon list right now. We can think about that in the further changes but now it is just implementation detail of the Closest mirror installation type.</div> <div><br> </div> <div>Cheers,</div> <div>Jirka</div> <div><br> </div> <div><br> </div> <div>On Fri, 2019-06-14 at 13:58 -0500, Pat Riehecky wrote:</div> <blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"> I noticed an unexpected behavior in Fedora 30.<br> <br> The net install disk for Workstation ships with the 'fedora-cisco-openh264' repo on the media. However, the repo is not listed under the 'Installation Source' spoke.<br> <br> Should this repo be loaded into the addons list?<br> <br> I suppose this is a bit of confusion based on this comment [1], vs the actual behavior where only `.treeinfo` repos that are also on disk get enabled [2]<br> <br> Thoughts?<br> <br> Pat<span class="pl-c1"><br> </span><br> <br> [1] <a class="moz-txt-link-freetext" href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rhinstaller_anaconda_blob_master_pyanaconda_payload_dnfpayload.py-23L1144&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=OAMtP0DWou0nlXG7Kmxo2enjXJfwb1DXS9fwcaESuTE&m=4-xXxdgOoCnvekEgB8jVaDu3MGGrgDnGFUaMz7MMSFk&s=B0w-OS-W3MPU5K5U51KiMPyq3dwSPG5SuWW2MrHCRkw&e=" moz-do-not-send="true">https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1144</a><br> <br> [2] self.addons seems to be populated via __init__.py and what it finds in `.treeinfo` I think.<br> <a class="moz-txt-link-freetext" href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rhinstaller_anaconda_blob_master_pyanaconda_payload_dnfpayload.py-23L1235&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=OAMtP0DWou0nlXG7Kmxo2enjXJfwb1DXS9fwcaESuTE&m=4-xXxdgOoCnvekEgB8jVaDu3MGGrgDnGFUaMz7MMSFk&s=i5wWiuUl9R3_Le1me-Iy9lCaUZuEI3drMwMtma91nz4&e=" moz-do-not-send="true">https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1235</a><br> <br> <pre>-- </pre> <pre>Pat Riehecky</pre> <pre> </pre> <pre>Fermi National Accelerator Laboratory</pre> <a class="moz-txt-link-abbreviated" href="http://www.fnal.gov" moz-do-not-send="true"> <pre>www.fnal.gov</pre> </a> <pre> </pre> <a class="moz-txt-link-abbreviated" href="https://urldefense.proofpoint.com/v2/url?u=http-3A__www.scientificlinux.org&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=OAMtP0DWou0nlXG7Kmxo2enjXJfwb1DXS9fwcaESuTE&m=4-xXxdgOoCnvekEgB8jVaDu3MGGrgDnGFUaMz7MMSFk&s=VyVahwNWo3mpwnQgX3h7iCokYyr0uwigGLpbTSdaH8s&e=" moz-do-not-send="true"> <pre>www.scientificlinux.org</pre> </a> <pre>_______________________________________________</pre> <pre>Anaconda-devel-list mailing list</pre> <a href="mailto:[email protected]" moz-do-not-send="true"> <pre>[email protected]</pre> </a> <pre> </pre> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__www.redhat.com_mailman_listinfo_anaconda-2Ddevel-2Dlist&d=DwMFaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=OAMtP0DWou0nlXG7Kmxo2enjXJfwb1DXS9fwcaESuTE&m=4-xXxdgOoCnvekEgB8jVaDu3MGGrgDnGFUaMz7MMSFk&s=DzCyh5T0G7g1PQIoJGcku9Cj5kRfmZHQ2OQlmM4sGUY&e=" moz-do-not-send="true"> <pre>https://www.redhat.com/mailman/listinfo/anaconda-devel-list</pre> </a></blockquote> </blockquote> <br> <pre class="moz-signature" cols="72">-- Pat Riehecky Fermi National Accelerator Laboratory <a class="moz-txt-link-abbreviated" href="http://www.fnal.gov">www.fnal.gov</a> <a class="moz-txt-link-abbreviated" href="http://www.scientificlinux.org">www.scientificlinux.org</a></pre> </body> </html> --------------D43C538A03CFF6E917410A24-- --===============7080581654285412061== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Anaconda-devel-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/anaconda-devel-list --===============7080581654285412061==--