Re: adding PowerNV as a new PPC machine type in the installer (rhbz#1303219)
Vendula Poncova <[email protected]> Wed, 26 Jun 2019 14:38:21 +0200
| Newsgroups | gmane.linux.redhat.anaconda.devel |
|---|---|
| Message-ID | <CAAmygTTvreP5Lq1GyksTBfiHZXd3MQzjLuc21-KgkdbCDdiHKQ@mail.gmail.com> |
--===============2814415187939442133== Content-Type: multipart/alternative; boundary="000000000000beb873058c3952bb" --000000000000beb873058c3952bb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 26, 2019 at 2:10 PM Dan Hor=C3=A1k <[email protected]> wrote: > On Mon, 24 Jun 2019 15:22:27 +0200 > Dan Hor=C3=A1k <[email protected]> wrote: > > > On Mon, 10 Jun 2019 15:26:21 +0200 > > Vendula Poncova <[email protected]> wrote: > > > > > On Mon, Jun 10, 2019 at 1:56 PM Dan Hor=C3=A1k <[email protected]> wrote: > > > > > > > Hi, > > > > > > > > there is a request for not installing the PReP partition on PPC > > > > system that don't really require it in bug 1303219 [1]. I've spend > > > > some time working on it and I think I have the solution, see [2] > > > > for details. Because the testing requires a bare-metal Power > > > > machine I'm now thinking how to allow testing it with the > > > > community in the least intrusive way. Right now my plan is to > > > > have the anaconda PR merged and use an updates.img for the > > > > corresponding blivet change. This way anaconda itself should work > > > > as before and only when used with the updates.img it should > > > > change the behaviour. What do you think? > > > > > > > > > > > Hello Dan, > > > the changes for anaconda seem to be safe and reasonable, so I think > > > we could merge them if you want to. > > > > > > As Jirka suggested, it is also possible to create one updates image > > > with anaconda and blivet changes. I can help you with that. > > > > finally I've managed to test both physical PowewNV hardware and a KVM > > guest and the is no problem in the installer. KVM guest installation > > works as before. The bare metal PowerNV one prints a error during the > > "bootloader installation" phase, but succeeds anyway. The problem is > > in grub due > > "grub2-install: error: the chosen partition is not a PReP partition." > > which will need fixing there by loosening that requirement. > > I think I have a solution for this problem as well. There is already a > request to loosen the check in grub2 [1], but IMHO a more appropriate > solution is to skip installing the grub binaries in anaconda and let > anaconda write only the grub config. Which could be achieved by > introducing of a PowerNVGRUB2 class with an empty install() method. > > That sounds good to me. Vendy > [1] https://bugzilla.redhat.com/show_bug.cgi?id=3D1723425 > > > Dan > > _______________________________________________ > Anaconda-devel-list mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/anaconda-devel-list --000000000000beb873058c3952bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">On Wed, Jun 26, 2019 at 2:10 PM Dan Hor=C3=A1k <<a href= =3D"mailto:[email protected]">[email protected]</a>> wrote:<br><div class=3D"gmail= _quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex= ;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, 24 Jun 20= 19 15:22:27 +0200<br> Dan Hor=C3=A1k <<a href=3D"mailto:[email protected]" target=3D"_blank">dan@da= nny.cz</a>> wrote:<br> <br> > On Mon, 10 Jun 2019 15:26:21 +0200<br> > Vendula Poncova <<a href=3D"mailto:[email protected]" target=3D"_= blank">[email protected]</a>> wrote:<br> > <br> > > On Mon, Jun 10, 2019 at 1:56 PM Dan Hor=C3=A1k <<a href=3D"mai= lto:[email protected]" target=3D"_blank">[email protected]</a>> wrote:<br> > > <br> > > > Hi,<br> > > ><br> > > > there is a request for not installing the PReP partition on = PPC<br> > > > system that don't really require it in bug 1303219 [1]. = I've spend<br> > > > some time working on it and I think I have the solution, see= [2]<br> > > > for details. Because the testing requires a bare-metal Power= <br> > > > machine I'm now thinking how to allow testing it with th= e<br> > > > community in the least intrusive way. Right now my plan is t= o<br> > > > have the anaconda PR merged and use an updates.img for the<b= r> > > > corresponding blivet change. This way anaconda itself should= work<br> > > > as before and only when used with the updates.img it should<= br> > > > change the behaviour. What do you think?<br> > > ><br> > > ><br> > > Hello Dan,<br> > > the changes for anaconda seem to be safe and reasonable, so I thi= nk<br> > > we could merge them if you want to.<br> > > <br> > > As Jirka suggested, it is also possible to create one updates ima= ge<br> > > with anaconda and blivet changes. I can help you with that.<br> > <br> > finally I've managed to test both physical PowewNV hardware and a = KVM<br> > guest and the is no problem in the installer. KVM guest installation<b= r> > works as before. The bare metal PowerNV one prints a error during the<= br> > "bootloader installation" phase, but succeeds anyway. The pr= oblem is<br> > in grub due<br> > "grub2-install: error: the chosen partition is not a PReP partiti= on."<br> > which will need fixing there by loosening that requirement.<br> <br> I think I have a solution for this problem as well. There is already a<br> request to loosen the check in grub2 [1], but IMHO a more appropriate<br> solution is to skip installing the grub binaries in anaconda and let<br> anaconda write only the grub config. Which could be achieved by <br> introducing of a PowerNVGRUB2 class with an empty install() method.<br> <br></blockquote><div>=C2=A0</div><div>=C2=A0That sounds good to me.</div><= div><br></div><div>Vendy<br></div><div></div><div>=C2=A0</div><blockquote c= lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli= d rgb(204,204,204);padding-left:1ex"> [1] <a href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1723425" rel= =3D"noreferrer" target=3D"_blank">https://bugzilla.redhat.com/show_bug.cgi?= id=3D1723425</a><br> <br> <br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Dan<br> <br> _______________________________________________<br> Anaconda-devel-list mailing list<br> <a href=3D"mailto:[email protected]" target=3D"_blank">Anacond= [email protected]</a><br> <a href=3D"https://www.redhat.com/mailman/listinfo/anaconda-devel-list" rel= =3D"noreferrer" target=3D"_blank">https://www.redhat.com/mailman/listinfo/a= naconda-devel-list</a></blockquote></div></div> --000000000000beb873058c3952bb-- --===============2814415187939442133== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Anaconda-devel-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/anaconda-devel-list --===============2814415187939442133==--