Re: [PATCH V2] pykickstart: don't set bootProto if --noipv4

Chris Lumens <[email protected]> Tue, 20 Oct 2015 11:01:21 -0400
Newsgroups gmane.linux.redhat.kickstart.general
Message-ID <[email protected]>
> If we specify a ipv6 only network configuration we still get bootproto=dhcp set,
> which during kickstart makes networkmanager try to do a ipv4 dhcp which takes a
> while to timeout.  We don't want bootproto=dhcp set when we specify --noipv4, so
> make sure it gets zero'ed out when we see that command.
> 
> Signed-off-by: Josef Bacik <[email protected]>
> ---
> V1-V2: only change --noipv4 behavior for F24 and onwards.
> 
>  pykickstart/commands/network.py | 13 +++++++++++++
>  pykickstart/handlers/f24.py     |  2 +-
>  tests/commands/network.py       | 14 ++++++++++++++
>  3 files changed, 28 insertions(+), 1 deletion(-)

Looks good to me.  Remember in anaconda you will have to update
kickstart.py to use the F24_Network class.

- Chris