Re: Uninteresting patches for hspell-1.0

Hi Bernard,

I am not familiar with the moral issues regarding the place of temporary files,
but I thank you for the patches. I have this deja vu feeling that we already
addressed the Tcl_DeleteHashTable mistake.. I wonder how it crept up again..

There is no publicly-available source repository for hspell. However we will
consider your patches when the time comes for a new version. Adding an entry in
our bugzilla is an even better method of ensuring that we remember this.

It sure seems that you've put in some effort and regard to details (down to the
order of the arguments to gcc); may I ask what is your interest in Hebrew
spelling?

Dan.

On Mon, Apr 02, 2007 at 02:18:56PM +0100, Bernard Leak wrote:
> Dear List,
>                   as a long-term hater of building in source directories,
> I've patched the hspell Makefile.in (and a few other bits and pieces)
> to allow building in a separate directory, in the Autotools way.
> 
> If there's a source repository against which I could check for recent
> changes, I've missed it.  I'm therefore patching against the 1.0 release.
> 
> I introduce two new dependencies:
> (a) I use VPATH.  Really, separate building is ugly as sin without it.
>     Merely defining it is harmless enough, of course, the point is that
>     the 'make' utility must respond to it - that, or just build in the
>     source directory (ugh) as before.
> (b) A redundant small change, but I prefer it:
>     I use 'install' to put everything where I want it.  This allows me
>     to collapse the cp / chmod sequences into single safe calls.
>     If you prefer to avoid this extra dependency, go back to cp and chmod,
>     but don't get rid of the extra $(SRCDIR)/ mini-paths I've added!
> 
> A separate patch cleans up a handful of miscellaneous warnings.
> Tcl_DeleteHashTable() was recklessly called without a prototype,
> and in fact was being mis-called, with an unused extra argument.
> 
> The patches are bzipped to avoid damage in transit.  The patches
> themselves use UN*X-style LF line-breaks.  Extra copies of the
> bzipped patches should be available for the foreseeable future in
> http://www.brenda-arkle.demon.co.uk/patches/hspell/
> 
> 
>                                                                         
> Happy patching...
> 
>                                                                         
>      Bernard Leak.
> 
> 
> 

-- 
Dan Kenigsberg        http://www.cs.technion.ac.il/~danken        ICQ 162180901
----
Ivrix-discuss list. See http://ivrix.org.il.
To unsubscribe, please send mail to [email protected] with
only the following line in the message body (NOT SUBJECT!): unsubscribe