Re: adding different compression types to createrepo

Anders F Björklund <[email protected]> Fri, 6 Aug 2010 12:25:27 +0200
Newsgroups gmane.linux.rpm.metadata
Message-ID <[email protected]>
> Bonus points for using "import lzma" instead of "| lzma",
> like utils.LzmaFile did*... That is, to use lzma.LZMAFile


In fact, that is probably a requirement... (lzma.LZMAFile)

There is nothing in the current patch that actually makes
sure that the "lzma" (or "xz") command has finished first,
before it looks at the resulting repodata temp output file.
This can result in the following repomd (note the file size):

   <data type="primary">
     <checksum  
type="sha256">e8960f94ce801d8ba6c514aaf07c9f64db0ca76461a56252fe94fc9068 
93377b</checksum>
     <timestamp>1281089005</timestamp>
     <size>841</size>
     <open-size>1657</open-size>
     <open-checksum  
type="sha256">55ca9c23daaa3ea30040cf5d98ee5fb16064d49aad2168ae01d82cbe9f 
83c390</open-checksum>
     <location href="repodata/primary.xml.gz"/>
   </data>
   <data type="primary_lzma">
     <checksum  
type="sha256">e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b78 
52b855</checksum>
     <timestamp>1281089005</timestamp>
     <size>0</size>
     <open-size>1657</open-size>
     <open-checksum  
type="sha256">55ca9c23daaa3ea30040cf5d98ee5fb16064d49aad2168ae01d82cbe9f 
83c390</open-checksum>
     <location href="repodata/primary.xml.lzma"/>
   </data>

It was supposed to be 821 bytes, but lzma hadn't finished...

--anders