Re: createrepo: initial comments and a UTF-8 patch

> I tested with some self-created nasty ones, as well as actual Conectiva
> packages.  Could not find a PLD package with "bad" chars in any of the
> fields in a quick search (but added ISO-8859-2 to the list of encodings
> to guess anyway, thinking about PLD :)
> 
> Note that if the conversion is unsuccessful, it falls back to the old
> "?" stuff.  And as said, the current code fails with stuff that is
> already in UTF-8.  Try any recent package by yours truly...

Cool. I'll take a look at some of the packages I used to test with and
see if they explode or not :) the most important thing is that xmllint
--noout doesn't have problems when we're done.

Thanks.

> Well, in my tests I could not find a case where libxml would not
> automatically do the string cleanup, ie. where createrepo would produce
> invalid XML without xmlCleanString() calls in place.  If you have a case
> where the auto-escaping does not happen, let me know.

When I was working on it originally libxml2-python wouldn't play nicely.
If it does now, then great, but I'm afraid of it blowing up on older
versions. I'll see if anything gets odd on older systems.

Thanks.



> Where?  I see RPMTAG_CHANGELOG{TIME,NAME,TEXT}, no author.

You're right. Sorry about that - but I always took name == person who
wrote the changelog so - author.


> 
> > I think just dumping the output as it occurs in the
> > rpm and letting the client program mangle it would be best.
> 
> Agreed, but isn't it that way already?  Changelog is stored in three
> arrays in the rpm header, not one big formatted lump.

And now each entry can be extracted from a list of tuples.

> Accidentally, .htaccess, something?  Whatever, I tend to think that
> createrepo should not choke on it.

So you'd rather it blew away your addition to that dir rather than
warning you about it?

-sv