Re: [Fwd: Re: yum 2.1.0]
seth vidal <[email protected]>
| Newsgroups | gmane.linux.rpm.metadata |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 2004-09-03 at 15:29, Ville Skyttä wrote: > On Fri, 2004-09-03 at 21:07, seth vidal wrote: > > > Take a look at this traceback. This happens after applying your patch. > > I'm going to work on it but if I remember correctly this is the reason > > why I didn't try to do too much tricky stuff with encoding conversion in > > createrepo. > > Hm, I don't think it's really that much about encoding conversion, but > just that utf8string() does not check for None, and rpmObj.tagByName() > in dumpMetaData.generateXML() behaves differently with nonexistent tags > on FC1 than it does on FC2: returns None on FC1, empty string on FC2. > > The attached patch is a quick fix for utf8string(); perhaps it would be > a good idea to additionally make tagByName() never return None but an > empty string instead so that it won't bite elsewhere later? You're right. Thanks for pointing that out. I'll get it patched up. -sv