Re: [PATCH] size comparison error
Tim Lauridsen <[email protected]>
| Newsgroups | gmane.linux.rpm.yum |
|---|---|
| Message-ID | <[email protected]> |
Perry Myers wrote:
> Small patch to correct a type comparison problem. The size comparison
> check always returns false. Casting the returnSimple to an int
> corrects the problem. The error results in packages being
> unnecessarily pulled on subsequent syncs.
>
> Thanks,
>
> Perry
>
> |/=- Red Hat, Engineering, Emerging Technologies, Boston. +1 703 362
> 9622 -=|/
>
> diff -Naur a/reposync.py b/reposync.py
> --- a/reposync.py 2007-05-31 15:48:40.000000000 -0400
> +++ b/reposync.py 2007-05-31 15:37:27.000000000 -0400
> @@ -212,7 +212,7 @@
> os.makedirs(localdir)
>
> if (os.path.exists(local) and
> - str(os.path.getsize(local)) ==
> pkg.returnSimple('packagesize')):
> + os.path.getsize(local) ==
> int(pkg.returnSimple('packagesize'))):
> if not opts.quiet:
> my.logger.error("[%s: %-5d of %-5d ] Skipping
> existing %s" % (repo.id, n, len(download_list), remote))
>
> _______________________________________________
> Yum mailing list
> [email protected]
> https://lists.dulug.duke.edu/mailman/listinfo/yum
Thanks,
Applied to yum-utils CVS
Tim