Re: 1.4.0-rc3 check_comp_rc: rc_role wrong?

Amon Ott <[email protected]>
Newsgroups gmane.linux.rsbac
Organization RSBAC
Message-ID <[email protected]>
On Monday 17 November 2008 19:32, Bernhard Seibold wrote:
> User 1000 is rc_role 4. No errors with 2.6.26.7 with 1.4.0-rc2 (and
> your one-line ipv6 patch).
>
> 0000009047|check_comp_rc(): pid 2299432064 (gweather-applet), owner
> 1000, rc_role 0, NETOBJ rc_type 0, request CREATE -> NOT_GRANTED!

The pid is complete rubbish here. Just corrected output at several 
places. I have attached a patch, can you please retry with it?

Amon.
-- 
http://www.rsbac.org - GnuPG: 2048g/5DEAAA30 2002-10-22

_______________________________________________
rsbac mailing list
[email protected]
http://www.rsbac.org/mailman/listinfo/rsbac
rc-pid.diff (text/x-diff, 4.9 KB)
=== rsbac/adf/rc/rc_main.c
==================================================================
--- rsbac/adf/rc/rc_main.c	(revision 2400)
+++ rsbac/adf/rc/rc_main.c	(local)
@@ -6,7 +6,7 @@
 /*                                                   */
 /* Author and (c) 1999-2008: Amon Ott <[email protected]> */
 /*                                                   */
-/* Last modified: 26/Feb/2008                        */
+/* Last modified: 18/Nov/2008                        */
 /*************************************************** */
 
 #include <linux/string.h>
@@ -129,7 +129,7 @@
 				    rsbac_kmalloc(RSBAC_MAXNAMELEN);
 				if (tmp2) {
 					rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %u, %s rc_type %u, request %s -> NOT_GRANTED!\n",
-						     caller_pid,
+						     pid_nr(caller_pid),
 						     current->comm,
 						     current->uid,
 						     i_attr_val1.rc_role,
@@ -175,7 +175,7 @@
 	} else {
 		char tmp[RSBAC_MAXNAMELEN];
 		rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %i, scd_type %i, request %s -> NOT_GRANTED!\n",
-			       caller_pid, current->comm, current->uid,
+			       pid_nr(caller_pid), current->comm, current->uid,
 			       i_attr_val1.rc_role, scd_type,
 			       get_request_name(tmp, request));
 		return NOT_GRANTED;
@@ -774,7 +774,7 @@
 			switch (i_rc_item_val1.type_id) {
 			case RC_type_no_create:
 				rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %u, def_process_create_type no_create, request CLONE -> NOT_GRANTED!\n",
-					       caller_pid, current->comm,
+					       pid_nr(caller_pid), current->comm,
 					       current->uid,
 					       i_attr_val1.rc_role);
 				return NOT_GRANTED;
@@ -872,7 +872,7 @@
 				return GRANTED;
 			case RC_type_no_create:
 				rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %u, def_fd_create_type no_create, request CREATE -> NOT_GRANTED!\n",
-					       caller_pid, current->comm,
+					       pid_nr(caller_pid), current->comm,
 					       current->uid,
 					       i_attr_val1.rc_role);
 				return NOT_GRANTED;
@@ -930,7 +930,7 @@
 			switch (i_rc_item_val1.type_id) {
 			case RC_type_no_create:
 				rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %u, def_ipc_create_type no_create, request CREATE -> NOT_GRANTED!\n",
-					       caller_pid, current->comm,
+					       pid_nr(caller_pid), current->comm,
 					       current->uid,
 					       i_attr_val1.rc_role);
 				return NOT_GRANTED;
@@ -994,7 +994,7 @@
 			switch (i_rc_item_val1.type_id) {
 			case RC_type_no_create:
 				rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %u, def_user_create_type no_create, request CREATE -> NOT_GRANTED!\n",
-					       caller_pid, current->comm,
+					       pid_nr(caller_pid), current->comm,
 					       current->uid,
 					       i_attr_val1.rc_role);
 				return NOT_GRANTED;
@@ -1057,7 +1057,7 @@
 			switch (i_rc_item_val1.type_id) {
 			case RC_type_no_create:
 				rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %u, def_group_create_type no_create, request CREATE -> NOT_GRANTED!\n",
-					       caller_pid, current->comm,
+					       pid_nr(caller_pid), current->comm,
 					       current->uid,
 					       i_attr_val1.rc_role);
 				return NOT_GRANTED;
@@ -1913,7 +1913,7 @@
 						     rc_def_role,
 						     attr_val.owner,
 						     RC_role_max_value,
-						     caller_pid,
+						     pid_nr(caller_pid),
 						     RSBAC_RC_GENERAL_ROLE);
 					i_attr_val1.rc_def_role =
 					    RSBAC_RC_GENERAL_ROLE;
@@ -2354,7 +2354,7 @@
 			switch (i_rc_item_val1.type_id) {
 			case RC_type_no_create:
 				rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %u, def_user_create_type no_create, request CREATE -> NOT_GRANTED!\n",
-					       caller_pid, current->comm,
+					       pid_nr(caller_pid), current->comm,
 					       current->uid,
 					       i_attr_val1.rc_role);
 				return -RSBAC_EDECISIONMISMATCH;
@@ -2428,7 +2428,7 @@
 			switch (i_rc_item_val1.type_id) {
 			case RC_type_no_create:
 				rsbac_pr_debug(adf_rc, "pid %u (%.15s), owner %u, rc_role %u, def_group_create_type no_create, request CREATE -> NOT_GRANTED!\n",
-					       caller_pid, current->comm,
+					       pid_nr(caller_pid), current->comm,
 					       current->uid,
 					       i_attr_val1.rc_role);
 				return -RSBAC_EDECISIONMISMATCH;
@@ -2502,7 +2502,7 @@
 					     tid.file.inode,
 					     MAJOR(tid.file.device),
 					     MINOR(tid.file.device),
-					     RC_role_max_value, caller_pid,
+					     RC_role_max_value, pid_nr(caller_pid),
 					     RC_default_root_dir_force_role);
 				i_attr_val1.rc_force_role =
 				    RC_default_root_dir_force_role;
@@ -2535,7 +2535,7 @@
 					     tid.file.inode,
 					     MAJOR(tid.file.device),
 					     MINOR(tid.file.device),
-					     RC_role_max_value, caller_pid,
+					     RC_role_max_value, pid_nr(caller_pid),
 					     RC_default_root_dir_initial_role);
 				i_attr_val2.rc_initial_role =
 				    RC_default_root_dir_initial_role;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.