Re: [PATCH v2 0/3] scsi: libiscsi: validate task lookups driven by target-supplied ITTs
Yehyeong Lee <[email protected]> Tue, 4 Aug 2026 15:24:23 +0900
| Newsgroups | gmane.linux.scsi,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
Two notes on the Sashiko reviews of 2/3 and 3/3, both marked pre-existing. On 2/3, the same validation is indeed needed for the other management responses in __iscsi_complete_pdu() - that is 3/3 in this series. The second question there, whether an in-flight SCSI read can complete without transferring data, is the third case in 2/3's changelog: a 1 MiB read returned 1048576 with none of its buffer written. The task->sc test is what blocks it. On 3/3 the reported lock inversion does not hold. iscsi_complete_pdu() takes back_lock (libiscsi.c:1358), iscsi_check_transport_timeouts() takes frwd_lock (libiscsi.c:2249). session->lock does not appear in libiscsi.c; the only mention left is a stale comment at libiscsi.h:131.