Re: [PATCH 0/2] scsi: zfcp: Enable CONTEXT_ANALYSIS

Bart Van Assche <[email protected]> Thu, 6 Aug 2026 09:36:38 -0700
Newsgroups gmane.linux.scsi
Message-ID <[email protected]>
On 8/6/26 6:47 AM, Heiko Carstens wrote:
> Enable CONTEXT_ANALYSYS for the zfcp driver.
> 
> Static code checking for acquiring and releasing locks used to be done
> with sparse. That was removed with [1] and replaced with a clang based
> approach [2]. The new approach requires that each subsystem needs to be
> explicitly enabled for checking.
> 
> Do that for drivers/s390/scsi. Add a __must_hold() attribute to
> zfcp_qdio_sbal_get() to address the only valid warning. Then enable
> CONTEXT_ANALYSIS, similar to other patches for drivers/s390 I'm currently
> working on.

These two patches could have been combined into a single patch. Anyway,
both patches look good to me.

Thanks,

Bart.