RE: [PATCH] scsi: fnic: Fix invalid comparison for error

On Friday, August 7, 2026 2:49 PM, Roman Demidov <[email protected]> wrote:
>
> The current comparison err != ERR_ECMDUNKNOWN is useless because err < 0
> and ERR_ECMDUNKNOWN == 5. The logic is that if the CMD_CAPABILITY
> command was executed, there is no need to respond to unknown errors.
> Therefore, the sign of the number in the comparison must be changed.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Roman Demidov <[email protected]>
> ---
> drivers/scsi/fnic/vnic_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c
> index 991c86eb5aff..0e5ae0540d85 100644
> --- a/drivers/scsi/fnic/vnic_dev.c
> +++ b/drivers/scsi/fnic/vnic_dev.c
> @@ -381,7 +381,7 @@ static int vnic_dev_cmd2(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd,
> if (result->color == color) {
> if (result->error) {
> err = -(int) result->error;
> -                             if (err != ERR_ECMDUNKNOWN ||
> +                             if (err != -ERR_ECMDUNKNOWN ||
> cmd != CMD_CAPABILITY)
> pr_err("%s:Error %d devcmd %d\n",
> pci_name(vdev->pdev),
> --
> 2.53.0
>
>

Thanks for this change, Roman. It looks good.

Reviewed-by: Karan Tilak Kumar <[email protected]>

Regards,
Karan