Re: [PATCH v6 05/56] scsi: qla2xxx: Add FC operational firmware load for 29xx
John Garry <[email protected]> Mon, 10 Aug 2026 15:27:01 +0100
| Newsgroups | gmane.linux.scsi |
|---|---|
| Organization | Oracle Corporation |
| Message-ID | <[email protected]> |
On 23/07/2026 06:03, Nilesh Javali wrote:
> +
> + if (section == TIM) {
> + if (section_size > req->length * qla_req_entry_size(ha)) {
> + ql_log(ql_log_fatal, vha, 0x0098,
> + "TIM section too large (0x%x bytes, ring 0x%lx bytes).\n",
> + section_size,
> + req->length * qla_req_entry_size(ha));
> + return QLA_FUNCTION_FAILED;
> + }
Not that this is generating a warning for i386 builds on the mkp-scsi
7.3 staging branch:
drivers/scsi/qla2xxx/qla_init.c: In function ‘qla29xx_process_rd_image’:
drivers/scsi/qla2xxx/qla_init.c:9272:53: error: format ‘%lx’ expects
argument of type ‘long unsigned int’, but argument 6 has type ‘size_t’
{aka ‘unsigned int’} [-Werror=format=]
9272 | "TIM section too large (0x%x bytes, ring 0x%lx bytes).\n",
| ~~^
| |
| long
unsigned int
| %x
9273 | section_size,
9274 | req->length * qla_req_entry_size(ha));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| size_t {aka unsigned int}
cc1: all warnings being treated as errors