Re: [PATCH 08/10] serial: ambarella: add Ambarella UART driver

On 30. 07. 26, 12:43, Long Zhao wrote:
> Add an Ambarella UART driver with console support for early boot
> bring-up on CV75. Keep udelay() in wait_for_tx(); it runs under
> console/poll paths that may hold the port lock with IRQs disabled.

Overall:
* use guarded locks (guard(), scoped_guard())
* rewrite console to nbcon, e.g. as in 8250 [1]
* can the i/o read/write+timeout helpers be applied here
* always add an i/o timeout
* do not cast void pointers:
   amb_port = (struct ambarella_uart_port *)(port->private_data);

[1] 
https://lore.kernel.org/all/20260729120439.281252-2-john.ogness-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org/

thanks,
-- 
js
suse labs