Re: [PATCH v2 4/4] serial: imx: serialize imx_uart_ports[] lifetime
Karl Mehltretter <[email protected]> Fri, 31 Jul 2026 15:54:02 +0200
| Newsgroups | gmane.linux.serial,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.kernel.stable |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Jul 30, 2026 at 04:31:51PM +0100, Greg Kroah-Hartman wrote: > > > > + mutex_lock(&imx_uart_ports_lock); > > guard()? > I'll use guards for v3. > > + unsigned int line = sport->port.line; > > Why are you reading this outside of the lock? > Good question. The local variable is unnecessary. I'll remove it. Thanks, Karl