Re: [PATCH v1 2/6] serial: txx9: Drop usage of uart_match_port()

Ilpo Järvinen <[email protected]> Mon, 3 Aug 2026 20:27:22 +0300 (EEST)
Newsgroups gmane.linux.serial,gmane.linux.kernel
Message-ID <[email protected]>
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1996484965-1785778042=:1172
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 31 Jul 2026, Uwe Kleine-K=C3=B6nig wrote:

> In this driver .iotype is always UPIO_PORT. So uart_match_port() is
> equivalent to comparing .iobase. Remove the call to uart_match_port()
> which then only has a single caller that is handled in the next commit.

Not directly related to the change. The txx9 driver seems to have some=20
iotype switch/cases as well so some !UPIO_PORT deadcode too.

--=20
 i.

> Signed-off-by: Uwe Kleine-K=C3=B6nig <[email protected]>
> ---
>  drivers/tty/serial/serial_txx9.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/serial/serial_txx9.c b/drivers/tty/serial/serial=
_txx9.c
> index 5ed20129b44b..2368081c3742 100644
> --- a/drivers/tty/serial/serial_txx9.c
> +++ b/drivers/tty/serial/serial_txx9.c
> @@ -965,7 +965,7 @@ static int serial_txx9_register_port(struct uart_port=
 *port)
>  =09mutex_lock(&serial_txx9_mutex);
>  =09for (i =3D 0; i < UART_NR; i++) {
>  =09=09uart =3D &serial_txx9_ports[i];
> -=09=09if (uart_match_port(uart, port)) {
> +=09=09if (uart->iobase =3D=3D port->iobase)
>  =09=09=09uart_remove_one_port(&serial_txx9_reg, uart);
>  =09=09=09break;
>  =09=09}
>=20

--8323328-1996484965-1785778042=:1172--