Re: [PATCH] serial: 8250_omap: fix wake irq cleared during suspend
Sebastian Andrzej Siewior <[email protected]>
| Newsgroups | gmane.linux.serial,gmane.linux.kernel,gmane.linux.kernel.stable |
|---|---|
| Message-ID | <[email protected]> |
On 2026-08-24 11:28:51 [-0500], Kendall Willis wrote: > The wake irq was cleared in shutdown(), which runs during the suspend > sequence, making it impossible to wake the system via UART. > Move wake irq setup to probe() and teardown to remove() so the irq > remains armed during suspend when the UART is a wakeup source. > > Cc: [email protected] > Fixes: 61929cf0169d ("tty: serial: Add 8250-core based omap driver") > Signed-off-by: Kendall Willis <[email protected]> I leave this to Tony. I tested it back then on bbb and wake up from idle was a requirement which worked. Tony had other boards which passed the test, too. The omap driver had and has the same logic here. Sebastian