Re: [PATCH 1/7] pmdomain: arm: Fix -EINVAL from scmi_pd_set_perf_state() on state 0
Abel Vesa <[email protected]>
| Newsgroups | gmane.linux.kernel.spi.devel,gmane.linux.ports.arm.kernel,gmane.linux.power-management.general,gmane.linux.kernel,gmane.linux.ports.arm.msm,gmane.linux.serial,gmane.linux.drivers.i2c |
|---|---|
| Message-ID | <2ah2wpjrqixhnws6y33tlkuep3et36q6typfd7ausgaslykmrb@cn6usezfkae6> |
On 26-08-05 01:27:39, Praveen Talari wrote: > Currently, scmi_pd_set_perf_state() treats a performance state of 0 as > invalid and returns -EINVAL. As a result, devices attached to SCMI > performance domains can report failures when relinquishing their > performance vote. > > The OPP framework use performance state 0 to indicate that no performance > vote is required. For example, dev_pm_opp_set_rate(dev, 0) is commonly > used (by firmware or linux) when a device is runtime suspended. > > A zero performance state does not require any SCMI performance request > to be sent. Treat it as a no-op and return success instead of reporting > an error. > > Signed-off-by: Praveen Talari <[email protected]> Reviewed-by: Abel Vesa <[email protected]>