Re: [PATCH] serial: 8250_omap: fix wake irq cleared during suspend

On 09:27-20260825, Sebastian Andrzej Siewior wrote:
> On 2026-08-24 11:28:51 [-0500], Kendall Willis wrote:
> > The wake irq was cleared in shutdown(), which runs during the suspend
> > sequence, making it impossible to wake the system via UART.
> > Move wake irq setup to probe() and teardown to remove() so the irq
> > remains armed during suspend when the UART is a wakeup source.
> > 
> > Cc: [email protected]
> > Fixes: 61929cf0169d ("tty: serial: Add 8250-core based omap driver")
> > Signed-off-by: Kendall Willis <[email protected]>
> 
> I leave this to Tony. I tested it back then on bbb and wake up from idle
> was a requirement which worked. Tony had other boards which passed the
> test, too.
> The omap driver had and has the same logic here.
> 
> Sebastian

Hi Sebastian,

When I was testing the dedicated wake irq on AM62P EVM, I was not seeing
the interrupt count increase for the wake irq in /proc/interrupts after
resume. This patch fixes that and after resume the wake irq interrupt
count increases when UART is a wakeup source.

Best,
Kendall