Re: [PATCH] ASoC: Intel: avs: da7219: Remove redundant DAI link name allocation
Cezary Rojewski <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.sound |
|---|---|
| Message-ID | <[email protected]> |
On 7/23/2026 11:36 AM, Linmao Li wrote: > avs_create_dai_link() assigns dl->name twice; the first devm_kasprintf() > is immediately overwritten by the TDM-aware name. Drop the redundant > first assignment. > > Signed-off-by: Linmao Li <[email protected]> > --- > sound/soc/intel/avs/boards/da7219.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/intel/avs/boards/da7219.c b/sound/soc/intel/avs/boards/da7219.c > index 2b17abcbd2bc..6cc8a6618fa1 100644 > --- a/sound/soc/intel/avs/boards/da7219.c > +++ b/sound/soc/intel/avs/boards/da7219.c > @@ -175,7 +175,6 @@ static int avs_create_dai_link(struct device *dev, int ssp_port, int tdm_slot, > if (!dl || !platform) > return -ENOMEM; > > - dl->name = devm_kasprintf(dev, GFP_KERNEL, "SSP%d-Codec", ssp_port); > dl->name = devm_kasprintf(dev, GFP_KERNEL, > AVS_STRING_FMT("SSP", "-Codec", ssp_port, tdm_slot)); > dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL); FWIW I've scanned the series [1] which introduced the issue. Looks like this is the only offending line. Thank you for addressing it: Reviewed-by: Cezary Rojewski <[email protected]> [1]: https://lore.kernel.org/all/[email protected]/