Re: [PATCH v2 2/4] ASoC: Intel: atom: remove conditional return with no effect

On 7/25/2026 6:03 PM, Sang-Heon Jeon wrote:
> Both branches of the check return the same value, so the check has
> no effect. Remove it and return the value directly.
> 
> This is the result of running the Coccinelle script from
> scripts/coccinelle/misc/cond_return_no_effect.cocci.
> 
> Signed-off-by: Sang-Heon Jeon <[email protected]>
> ---
>   sound/soc/intel/atom/sst-mfld-platform-pcm.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
> index 9ee4d9926e06..a4c8cbfba096 100644
> --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c
> +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
> @@ -236,12 +236,7 @@ static int sst_platform_alloc_stream(struct snd_pcm_substream *substream,
>   
>   	stream->stream_info.str_id = str_params.stream_id;
>   
> -	ret_val = stream->ops->open(sst->dev, &str_params);
> -	if (ret_val <= 0)
> -		return ret_val;
> -
> -
> -	return ret_val;
> +	return stream->ops->open(sst->dev, &str_params);
>   }
>   
>   static void sst_period_elapsed(void *arg)

Reviewed-by: Cezary Rojewski <[email protected]>