Re: [PATCH RFC 5/6] ASoC: cs35l36: Implement set_tdm_slot to program RX slot register

Charles Keepax <ckeepax-yzvPICuk2AA4QjBA90+/[email protected]>
Newsgroups gmane.linux.drivers.devicetree,gmane.linux.sound,gmane.linux.ports.arm.msm,gmane.linux.kernel
Message-ID <[email protected]>
On Wed, Jul 29, 2026 at 08:22:42PM +0200, David Heidelberg wrote:
> On 06/07/2026 10:52, Charles Keepax wrote:
> > On Sun, Jul 05, 2026 at 10:06:55PM +0200, David Heidelberg via B4 Relay wrote:
> > > +	if (rx_mask)
> > > +		regmap_update_bits(cs35l36->regmap, CS35L36_ASP_RX1_SLOT,
> > > +				   CS35L36_ASP_RX1_SLOT_MASK,
> > > +				   ffs(rx_mask) - 1);
> > 
> > It is more normal for the masks to specify the slot number rather
> > than the bit number, it would probably be nicer to stick with
> > that convention even though it will complicate the code here a
> > little.
> 
> Thank you, is there one of the cs*l* series which implements in similar
> fashion as requested?

sound/soc/codecs/arizona.c, sound/soc/codecs/cs42l43.c or
sound/soc/codecs/cs35l56.c all implement set_tdm, those are
probably reasonable inspiration.

Thanks,
Charles
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.