Re: [PATCH RFC 2/3] ASoC: codecs: tfa98xx: add driver for TFA2 amplifiers

Uwe Kleine-König <[email protected]> Mon, 3 Aug 2026 00:17:24 +0200

Newsgroups	gmane.linux.sound,gmane.linux.drivers.devicetree,gmane.linux.kernel,gmane.linux.ports.arm.msm
Message-ID	<am_BahJARF9z0P0u@monoceros>

Hello,

On Sun, Aug 02, 2026 at 02:42:41PM +0200, David Heidelberg wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>

Please don't include <linux/mod_devicetable.h>, that is going away soon.
Also <linux/i2c.h> already provides i2c_device_id and of_device_id
(ie. the two structures that used to be defined in
<linux/mod_devicetable.h> that you're using), so just drop the #include
for <mod_devicetable.h>.

> [...]
> +static const struct i2c_device_id tfa98xx_i2c_id[] = {
> +	{ "tfa9894", (kernel_ulong_t)&tfa9894_chip },

Please make this

	{ .name = "tfa9894", .driver_data = (kernel_ulong_t)&tfa9894_chip },

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)