Re: [PATCH v2 2/4] ASoC: renesas: enable COMPILE_TEST for PCM SH7760

Kuninori Morimoto <[email protected]> Tue, 4 Aug 2026 00:59:23 +0000
Newsgroups gmane.linux.sound
Message-ID <[email protected]>
Hi Mark, Geert

Thank you for your review

> > PCM SH7760 is not compiled with COMPILE_TEST, and there is no defconfig
> > which selects it. So it is easy to be overlooked for compile test and/or
> > ASoC updating.
> 
> > -	depends on CPU_SUBTYPE_SH7760 && SH_DMABRG
> > +	depends on SUPERH || ARCH_SHMOBILE
> > +	depends on (CPU_SUBTYPE_SH7760 && SH_DMABRG) || COMPILE_TEST
> 
> SH_DMABRG looks like an actual dependency, there's custom IRQ request
> and free functions which don't have stubs.

Ah...
SH_DMABRG itself is depends on CPU_SUBTYPE_SH7760.
So I think it should be "select" instead of "depends",
like below.

	depends on SUPERH || ARCH_SHMOBILE
	depends on CPU_SUBTYPE_SH7760 || COMPILE_TEST
	select SH_DMABRG

Thank you for your help !!

Best regards
---
Kuninori Morimoto