Re: [PATCH v2 3/4] ASoC: renesas: enable COMPILE_TEST for AC97 SH7760

Hi Morimoto-san,

On Mon, 3 Aug 2026 at 03:55, Kuninori Morimoto
<[email protected]> wrote:
> AC97 SH7760 is not compiled with COMPILE_TEST, and there is no defconfig
> which selects it. So it is easy to be overlooked for compile test and/or
> ASoC updating.
>
> Let's enable COMPILE_TEST when it was for SuperH / SH-Mobile
>
> Then, remove #error which hinder for compile test.
>
> Signed-off-by: Kuninori Morimoto <[email protected]>

Thanks for your patch!

> --- a/sound/soc/renesas/Kconfig
> +++ b/sound/soc/renesas/Kconfig
> @@ -63,7 +63,8 @@ config SND_SOC_RZ
>
>  config SND_SH7760_AC97
>         tristate "SH7760 AC97 sound support"
> -       depends on CPU_SUBTYPE_SH7760 && SND_SOC_PCM_SH7760
> +       depends on SUPERH || ARCH_SHMOBILE

You can drop the ARCH_SHMOBILE part, as it is a subset of SUPERH
(if ARCH_SHMOBILE is enabled, SUPERH is enabled, too).

> +       depends on (CPU_SUBTYPE_SH7760 && SND_SOC_PCM_SH7760) || COMPILE_TEST

You can drop the CPU_SUBTYPE_SH7760 part, as SND_SOC_PCM_SH7760
depends on CPU_SUBTYPE_SH7760.

>         select SND_SOC_SH4_HAC
>         select SND_SOC_AC97_CODEC
>         help

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds