Re: [PATCH v2 2/4] ASoC: renesas: enable COMPILE_TEST for PCM SH7760

Hi Geert

Thank you for your review

> > > > -   depends on CPU_SUBTYPE_SH7760 && SH_DMABRG
> > > > +   depends on SUPERH || ARCH_SHMOBILE
> 
> You can drop the ARCH_SHMOBILE part, as it is a subset of SUPERH
> (if ARCH_SHMOBILE is enabled, SUPERH is enabled, too).

Will do

> > > SH_DMABRG looks like an actual dependency, there's custom IRQ request
> > > and free functions which don't have stubs.
> >
> > Ah...
> > SH_DMABRG itself is depends on CPU_SUBTYPE_SH7760.
> > So I think it should be "select" instead of "depends",
> > like below.
> >
> >         depends on SUPERH || ARCH_SHMOBILE
> >         depends on CPU_SUBTYPE_SH7760 || COMPILE_TEST
> >         select SH_DMABRG
> 
> 1. "depends on SH_DMABRG" should be fine, as SH_DMABRG is a
>     user-visible symbol,
> 2. SH_DMABRG depends on CPU_SUBTYPE_SH7760, so you cannot just select
>     it without enabling compile-testing for SH_DMABRG first.

Do we need to use "depends" for it ?

SH_DMABRG is indeed defined as user-visible, but is needed only for Sound
(and/or USB ?). It is specific/necessary feature, not generic feature.

In this case, it should be selected automatically if Sound (and/or USB) was
selected, IMO. In such case, we can compile with COMPILE_TEST ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto