Re: [PATCH 08/10] ASoC: ti: omap-twl4030: Return the original error code
Bui Duc Phuc <[email protected]> Wed, 5 Aug 2026 10:24:13 +0700
| Newsgroups | gmane.linux.sound,gmane.linux.ports.arm.omap,gmane.linux.kernel |
|---|---|
| Message-ID | <CAABR9nFc-7HnB_4FKXGaRzA=SuGCy1dT=vWUn+Sjq62BqLT7WQ@mail.gmail.com> |
Hi Andreas, Thanks for the review. > The error message seems that is wants to catch a non-existant property. > snd_soc_of_parse_card_name() seems to ignore that error. Which is then > really catched by devm_snd_soc_register_card(). It would be good to > point out the error explicitely, so probably printing that error message > on if (!card->name) > You're right, I can't be sure what the original author's intent was here. But as you pointed out, we do need to also check for if (!card->name), since snd_soc_of_parse_card_name() silently ignores a missing property and only returns an error for other cases. This patch has already been merged, so I'll send a separate patch to address this. Best regards, Phuc