Re: [PATCH 13/31] ASoC: rt1320-sdw: Use auto-cleanup for firmware loading

On Thu, Aug 06, 2026 at 09:37:14AM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > There's a goto further up that jumps over this which clang warns about,
> > this will break the build.  Landmines like that are why cleanup.h warns
> > about mixing it with goto.

> That's an issue because I moved the declaration of the variable fw;
> if it's left at the beginning of the function as it was, it should
> work fine, like the patch below.  The same applied to the error for
> wm2000.

Yes, it's fine when the declaration is at the beginning IIRC (though not
ideal stylistically) - the warning is generated when a goto jumps over a
declaration.

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmp0dY8ACgkQJNaLcl1U
h9C6yQf+OMoRXkIq2PP1l3mVKOKAqkpHdj2ktUx0hTYSRlFhB+FViNrzHoYRWCPj
UKfH+BE49GfbPW8EWO/tSuY0795s5+ySq0WU0kEGpoJI5DMWCCDYMymu4BghI2yw
O1tlWyIhOd2/PGxffwElPOcR1Cp3nvmptBXK2MwssiH6DlYOWqYEW2kZcpuP3pjy
Jt/0s6bSWJi3YNJNFyPCd76JN0dRCluMBOsSUGSSz471FBjkqBSWwNy4cj/jvFgt
exm+pkgd6f+jcSyBIXv7NtRV7rHZMbH11bQQz1lI6ilOLikEhcx/wanS6X4bptCY
9YQDDT+uqijgYrEqO7SJjwvG9WfrNA==
=daLm
-----END PGP SIGNATURE-----