Re: [PATCH v3 1/5] ASoC: dt-bindings: fsl,imx-asrc: update port binding to support multiple paths
Krzysztof Kozlowski <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.sound,gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel,gmane.linux.kernel |
|---|---|
| Message-ID | <20260810-normal-cuscus-of-argument-4b230b@quoll> |
On Tue, Aug 04, 2026 at 06:02:14PM +0800, [email protected] wrote: > From: Shengjiu Wang <[email protected]> > > The i.MX ASRC hardware supports up to three conversion pairs (A, B, C). Which SoC? Did you read this binding you are changing? > The existing binding exposed only a single generic audio-graph port, > which cannot represent independent conversion paths when multiple pairs > are in use simultaneously. > > Add a ports container that enumerates up to three sub-ports, each > representing an independent conversion path: > port@0 -- conversion path 0 > port@1 -- conversion path 1 > port@2 -- conversion path 2 > > Each sub-port references audio-graph-port.yaml as before. Hardware pairs > are allocated dynamically at stream open time; each active stream > direction (playback or capture) on a port consumes one hardware pair. > > For backwards compatibility, keep the old single port property but mark Why? Did the old hardware change that it has more ports/paths? > it deprecated. A schema constraint (not: required: [port, ports]) ensures > that both forms cannot be used at the same time. The binding example is > updated to show the preferred ports form. > > No existing upstream DTS file for fsl,imx-asrc uses the previously > documented single 'port' node, so this change does not break any > in-tree device tree. Does it break other users of this binding? Why mentioning upstream in the first place? Either this change breaks ABI or not, explain that. Best regards, Krzysztof