Re: [PATCH 0/3] ASoC: tas2783: fix stereo split and resume on a two-amp pair

Robin Everaars <[email protected]>
Newsgroups gmane.linux.sound,gmane.linux.kernel
Message-ID <[email protected]>
> Robin, Antoine, Andrey -- if you would like Reported-by: or Suggested-by:
> on any of this, say so and I will add it; I did not want to attach your
> names to a series you have not seen.

For patch 2, please add both:

  Reported-by: Robin Everaars <[email protected]>
  Suggested-by: Robin Everaars <[email protected]>

The report and the follow-up measurement established both the one-channel mask
approach and the positional behaviour in sdw_compute_slave_ports(), so those
tags fit. I have no basis for a tag on patches 1 or 3.

I also retested the machine today after booting kernel 7.1.7. The cold-boot path
still fails on the second amplifier:

  command timeout for Slave 2
  trf on Slave 2 failed:-110 write addr 8088 count 32632
  FW download failed: -110
  SDW1 manager is in bad state

The existing reprobe service recovered both amplifiers on its first attempt.
A fresh acoustic run after that recovery gave:

  LEFT only    +69.0 dB over baseline
  RIGHT 
only   +64.4 dB over baseline
  BOTH         +71.0 dB over baseline
  imbalance     +4.6 dB

Both channels reached the speakers.

That measurement only establishes the 7.1.7 baseline; I did not run your
series. My configured out-of-tree module still carries the local per-amp PPU21
write that Pierre correctly rejected as an upstream mechanism. I therefore am
not offering a Tested-by or Reviewed-by for patch 2 yet. I also have not
isolated the residual dev_resume() path for patch 3 on top of b627da430357.

The boot failure is why I am keeping both the boot and resume reprobe services
for now. I will remove them only after the unassisted paths work upstream.

Thanks for the careful follow-up and for separating the prior work from the new
parts of the series.
publickey - [email protected] - 0x8B6BA132.asc (application/pgp-keys, 889 B)
-----BEGIN PGP PUBLIC KEY BLOCK-----
Comment: https://gopenpgp.org
Version: GopenPGP 2.10.0

xjMEah8lZRYJKwYBBAHaRw8BAQdAaRkzve49rBEJMKJH746RXHY+2fT77oxROi5d
8JpL+67NKXJvYmluZXZlcmFhcnNAcG0ubWUgPHJvYmluZXZlcmFhcnNAcG0ubWU+
wsARBBMWCgCDBYJqHyVlAwsJBwkQHcV/a8sGGopFFAAAAAAAHAAgc2FsdEBub3Rh
dGlvbnMub3BlbnBncGpzLm9yZx6V5qS89w7CDYSIsc5NxuPJI1rgoEyY/v8dbP3H
qkoNAxUKCAQWAAIBAhkBApsDAh4BFiEEi2uhMrb2XujFnFjLHcV/a8sGGooAAAZs
AP9zIKWwubClFEs0J6jpQHTKXFTq+99MRkfDKqITbumQzQD/R2OazTp4oCJO2bOD
NFliVAm8yXP6A+586zR2YKt0RAbOOARqHyVlEgorBgEEAZdVAQUBAQdA3p5F7b5O
FsWKrSWEmEHia/oe7no/+Z1W0OPffYrDPy8DAQgHwr4EGBYKAHAFgmofJWUJEB3F
f2vLBhqKRRQAAAAAABwAIHNhbHRAbm90YXRpb25zLm9wZW5wZ3Bqcy5vcmevUdR+
V+3UgvIVjqDLFOWyyGp5h4JXAPfYZsD//RHgvQKbDBYhBItroTK29l7oxZxYyx3F
f2vLBhqKAABoFgEA8e4eSLSaLmv8/e2W1L9/VKAbj2Z7JES6KApi9BZ6nQgBANhZ
FhMFzsyzu2YYtaB8SYtVthJJ6/eIQTT6UdQEIYsF
=YKhM
-----END PGP PUBLIC KEY BLOCK-----
signature.asc (application/pgp-signature, 322 B)
-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wqsEARYIAF0Fgmp7GhkJEB3Ff2vLBhqKNRQAAAAAABwAEHNhbHRAbm90YXRp
b25zLm9wZW5wZ3Bqcy5vcmclLcVay0A9nErKERvPCwpnFiEEi2uhMrb2XujF
nFjLHcV/a8sGGooAAOayAQCgSfzOjleAD57mHM8kw+ax1yQuYobbPLpuGhmo
2f8qOQD+PM8r6gdXfOonFkiX9PCT2OPRPNE0fy+8/cOF7TiXmQ4=
=5Dv3
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.