Re: [PATCH v2] ALSA: hda/realtek: Add mute LED quirk for HP 250 G8 (0x85f3)
Takashi Iwai <[email protected]>
| Newsgroups | gmane.linux.sound |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 11 Aug 2026 15:46:34 +0200, Bramwel Barack wrote: > > The HP 250 G8 Laptop PC (subsystem 103c:85f3) using the Realtek ALC236 > codec requires a specific quirk to enable the mute button LED. > Currently, the audio mutes in software, but the physical indicator > light remains unlit. > > Adding a quirk entry to the alc236_fixup_tbl with the > ALC236_FIXUP_HP_MUTE_LED_COEFBIT2 fixup correctly maps the > LED to the mute state via COEF index 0x07. > > Signed-off-by: Bramwel Barack <[email protected]> > --- > v2: > - Added technical description of the COEF bit mapping. > - Fixed spacing error in the quirk entry. > - Updated mailing list to [email protected]. It's almost done... > > sound/hda/codecs/realtek/alc269.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c > index 379e1458f4ac..74af2f9e26af 100644 > --- a/sound/hda/codecs/realtek/alc269.c > +++ b/sound/hda/codecs/realtek/alc269.c > @@ -7153,6 +7153,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8811, "HP Spectre x360 15-eb1xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1), > SND_PCI_QUIRK(0x103c, 0x8812, "HP Spectre x360 15-eb1xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1), > + SND_PCI_QUIRK(0x103c, 0x85f3, "HP 250 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), > SND_PCI_QUIRK(0x103c, 0x881d, "HP 250 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), > SND_PCI_QUIRK(0x103c, 0x881e, "HP Laptop 15s-du3xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), The table is sorted in PCI SSID order. Please put the new entry at the right position. thanks, Takashi