Re: [PATCH 2/6] ASoC: samsung: aries_wm8994: Drop redundant probe error messages
Cezary Rojewski <[email protected]>
| Newsgroups | gmane.linux.sound,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/12/2026 4:59 AM, Bui Duc Phuc wrote: >> To be fair, xxx_snd_soc_register_component(), both the devres and the >> non-devres equivalent do not report anything. The >> component_initialize() and component_add() do though, most of the time. >> > > Yes, you're right. I checked and all the error paths before returning already > log an error, except for -ENOMEM, which by convention doesn't need to be logged. > > I'll update the commit message to clarify that the error is logged deeper in > the call chain rather than by the function called directly. Something like: > > ------- > The functions called here don't log the error themselves, but the > error is already reported deeper in the call chain, so the dev_err() > calls are redundant and can be removed. > ------- > Does this look accurate to you? Looks good.