Re: Re: [PATCH v2] ASoC: tas2783-sdw: add firmware download status check

"Xu, Baojun" <[email protected]>
Newsgroups gmane.linux.sound,gmane.linux.alsa.devel,gmane.linux.kernel
Message-ID <[email protected]>
> On Thu, Aug 13, 2026 at 10:14:50AM +0800, Baojun Xu wrote:
> > Currently, the firmware download is unnecessarily triggered on every
> > system resume from suspend, causing significant wake-up latency. However,
> > this step is redundant if the AMP remains powered on. Furthermore, certain
> > memory pages (addresses > 0xc60000) are skipped even after an AMP reset.
> 
> > +             if (!tas_dev->first_hw_init || file->dest_addr < 0xc60000) {
> > +                     ret = sdw_nwrite_no_pm(tas_dev->sdw_peripheral,
> > +                                            file->dest_addr,
> > +                                            file->length,
> +                                            file->fw_data);
> 
> What happens if the amplifier uses power (eg, over a system suspend)?
> Though since nothing clears first_hw_init I guess there might be issues
> there anyway...
Hi Mark,
Yes, that is the purpose of this patch. It prevents the re-downloading of
pages above 0xC60000 after resuming from suspend, as the data in this region
persists across an AMP reset. Therefore, these pages should only be downloaded
during the initial power-up (when first_hw_init is false).

Best Regards
Jim
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.