Re: [PATCH v2 2/2] ASoC: tas2783-sdw: do not cache read-only Controls
Mark Brown <[email protected]>
| Newsgroups | gmane.linux.sound,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Aug 14, 2026 at 09:40:00AM +0300, Andrey Golovko wrote:
> The read-only SDCA Controls are readings of device state, but the regmap
> caches them and tas2783_reg_default[] gives each one a placeholder, so a
> read is answered from the cache and never reaches the peripheral. The
> static bool tas2783_volatile_register(struct device *dev, u32 reg)
> {
> + if (tas2783_read_only_control(reg))
> + return true;
> +
Does this work for multibyte reads? The regmap has val_size set to 8
but some of the read only registers are multibyte. For SoundWire
val_bits doesn't really matter so you should just be able to set that to
32.
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmp/MKUACgkQJNaLcl1U h9BKdgf7BGMc1lwk3Sc+fI/9MjG1d9LtnFVFczPq6XcD943nq+M8GSDpeW+0ISGb FB+3tmzmknZqPZAE4Ar0xo6TVeX7WGUvNqTuiBwh76y0Ml14hJhFRY+a/Ala2b+H UPYajuoN9kpnCVcc3O9Le3m6nDv+q+xROy/FqStHmo6nIt86wZ05i2mtoB+9X+9h hNY3z1lC/IPGkgwesjvzDHeukpr8u4FBRRlKYTZUHMI60Y3513POum/0uDNwvJ1q i0ylYtGTaf+tFAhNb5VMiO5fYsQLtizxpi0ddng6GlkcqW7u8RVagiHUqFKqODwe 5MWcEGKJGoRZcxRK0AmtQOT4Hvpkgg== =qUJv -----END PGP SIGNATURE-----