Re: [PATCH] ALSA: hda/realtek: Fix mute LED for HP Victus 15-fa1xxx (MB 8C3F)

On Sat, 15 Aug 2026 18:33:12 +0200,
Yashraj221B wrote:
> 
> The HP Victus 15-fa1xxx with motherboard 8C3F is missing the
> existing mute LED quirk for ALC245 codecs.
> 
> Add the 103c:8c3f subsystem ID to the existing
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT quirk.
> 
> Tested on HP Victus 15-fa1xxx (MB 8C3F). The mute LED works
> as intended.
> 
> Signed-off-by: Yashraj221B <[email protected]>

The Signed-off-by tag is a legal requirement, and it must be with a
real name (or a known identity).  At best, change From: address to
align with it altogether.

Also, about the code change:

> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 3f0e276fc606..df0732c5e14d 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7470,6 +7470,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8c17, "HP Spectre x360 2-in-1 Laptop 16-aa0xxx", ALC245_FIXUP_HP_SPECTRE_X360_16_AA0XXX),
>  	SND_PCI_QUIRK(0x103c, 0x8c21, "HP Pavilion Plus Laptop 14-ey0XXX", ALC245_FIXUP_HP_X360_MUTE_LEDS),
>  	SND_PCI_QUIRK(0x103c, 0x8c2d, "HP Victus 15-fa1xxx (MB 8C2D)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
> +	SND_PCI_QUIRK(0x103c, 0x8c3f, "HP Victus 15-fa1xxx (MB 8C3F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
>  	SND_PCI_QUIRK(0x103c, 0x8c30, "HP Victus 15-fb1xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
>  	SND_PCI_QUIRK(0x103c, 0x8c46, "HP EliteBook 830 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8c47, "HP EliteBook 840 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),

The table is sorted in PCI SSID order.  Please put the new entry at
the right position.

Could you resubmit with the corrections above?  Thanks.


Takashi