Re: [PATCH v2 04/44] ASoC: codecs: adau*: use .auto_selectable_formats
Kuninori Morimoto <[email protected]>
| Newsgroups | gmane.linux.sound |
|---|---|
| Message-ID | <[email protected]> |
Hi Mark Thank you for your review > > diff --git a/sound/soc/codecs/adau1977.c b/sound/soc/codecs/adau1977.c > > index b42f35b1a6036..b9d9853934216 100644 > > --- a/sound/soc/codecs/adau1977.c > > +++ b/sound/soc/codecs/adau1977.c > > @@ -741,6 +741,17 @@ static int adau1977_set_tristate(struct snd_soc_dai *dai, int tristate) > > ADAU1977_SAI_OVERTEMP_DRV_HIZ, val); > > } > > > > +static const u64 adau1977_selectable_formats = > > + SND_SOC_POSSIBLE_DAIFMT_I2S | > > + SND_SOC_POSSIBLE_DAIFMT_RIGHT_J | > > + SND_SOC_POSSIBLE_DAIFMT_LEFT_J | > > + SND_SOC_POSSIBLE_DAIFMT_DSP_A | > > + SND_SOC_POSSIBLE_DAIFMT_DSP_B | > > + SND_SOC_POSSIBLE_DAIFMT_NB_NF | > > + SND_SOC_POSSIBLE_DAIFMT_NB_IF | > > + SND_SOC_POSSIBLE_DAIFMT_IB_NF | > > + SND_SOC_POSSIBLE_DAIFMT_IB_IF; > > + > > This looks like another one where not all combinations are supported - > the DSP formats look like they disable invered LRCLK? Hmm... From code point of view, "invert_lrclk" looks handling "block_power" only. RIGHT_J/LEFT_J are also updating it. It does not appear that the combination is prohibited ? Thank you for your help !! Best regards --- Kuninori Morimoto