Re: [PATCH 23/44] ASoC: codecs: max*: use .auto_selectable_formats
Kuninori Morimoto <[email protected]>
| Newsgroups | gmane.linux.sound |
|---|---|
| Message-ID | <[email protected]> |
Hi Peter
> /* Remove 24-bit format support if it is not in right justified mode. */
> if ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) != SND_SOC_DAIFMT_RIGHT_J) {
> substream->runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
> snd_pcm_hw_constraint_msbits(substream->runtime, 0, 16, 16);
> }
>
> Should RIGHT_J be preferred over I2S/LEFT_J/DSP_A for that codec?
Yes indeed. Thank you for pointing it.
Let's set priority for them.
> I started looking at max98088 before proceeding to max98090 when the
> above problem was spotted. I then stopped looking. It wasn't exactly
> hard to find an example.
Yeah, it is too many drivers and many patterns...
Thank you for your help !!
Best regards
---
Kuninori Morimoto