Re: [PATCH] ASoC: Intel: soc-acpi-intel-ptl-match: add rt721_l3_rt1320_l3
Sataporn Saijai <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.sound |
|---|---|
| Message-ID | <CAHgGaxwrLQ3+gKSSxnOBYMYFRgcbQG9eHc6xy-i0DsKhVY7zTQ@mail.gmail.com> |
On Mon, Aug 17, 2026 at 10:56 PM Mark Brown <[email protected]> wrote: > Will this match on other systems that have additional components, or > more SDCA functions active? Yes, it is loose. snd_soc_acpi_sdw_link_slaves_found() only checks specific device IDs (like part_id, mfg_id, sdw_version, and link_id) and ignores any other peripheral hardware. I tested this by adding a temporary ptl_sdw_rt721_l3_rt722_l3_rt1320_l3 entry above the ptl_sdw_rt721_l3_rt1320_l3 entry. I kept the same kernel, only changing the dmi-quirks.c: with the quirk: spk:rt721+rt1320 no errors, audio works properly. without the quirk: spk:rt721+rt722+rt1320 hs:rt722 mic:rt722, the system fails at prepare with -61 and there is no audio. This is because an entry covering all three parts would match this machine on the ghost RT722, even though it never attaches. The failure is silent, the card registers and aplay reports success. I could not test the cross-link case, this machine only has link 3 populated. For the SDCA functions, I will use jack_amp_g1_dmic_endpoints for the RT721 instead of amp only. This machine only declares the amp and the codec driver skips the other two, so any board wiring the jack and DMICs gets those links as well: rt721-sdca sdw:0:3:025d:0721:01: SDCA device function for DAI type 0 not supported, skip endpoint rt721-sdca sdw:0:3:025d:0721:01: SDCA device function for DAI type 2 not supported, skip endpoint Initially, I looked into updating the match table. But then I figured out it isn't needed, just adding the quirk is enough. No SoundWire machine driver found for the ACPI-reported configuration: link 3 mfg_id 0x025d part_id 0x0721 version 0x3 link 3 mfg_id 0x025d part_id 0x1320 version 0x3 Use SoundWire default machine driver with function topologies The default machine driver builds the same configuration once the ghost is removed, so the match entry is not required on this machine. By the way, I noticed ptl_rt721_l0 and ptl_rt721_l3 were dropped in 7.2 (they were there in 6.18). Was that removed on purpose to use the default machine driver? If so I will just send the DMI quirk.